Fix Version Notation and Add Dynamic Support for Version Categorization #19327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etching of supported and unsupported versions
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
taroface
previously requested changes
Jan 28, 2025
Contributor
taroface
left a comment
taroface
left a comment
There was a problem hiding this comment.
A few small requests -- let me know if anything doesn't make sense to you.
florence-crl
approved these changes
Mar 5, 2025
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
LGTM non-blocking nit
| {% if is_unsupported %} | ||
| CockroachDB {{ v.major_version }} is completely unsupported. {% if is_innovation %}This was an Innovation release{% else %}This was a Regular release{% endif %} that reached end-of-support on {% if is_innovation %}{{ v.maint_supp_exp_date }}{% else %}{{ v.asst_supp_exp_date }}{% endif %}. | ||
| {% else %} | ||
| CockroachDB {{ v.major_version }} is partially supported. Pre-LTS patches (before {{ v.initial_lts_patch }}) are no longer supported, but LTS patches ({{ v.initial_lts_patch }} and later) are still covered under the LTS support policy until {{ v.lts_asst_supp_exp_date }}. |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| CockroachDB {{ v.major_version }} is partially supported. Pre-LTS patches (before {{ v.initial_lts_patch }}) are no longer supported, but LTS patches ({{ v.initial_lts_patch }} and later) are still covered under the LTS support policy until {{ v.lts_asst_supp_exp_date }}. | |
| CockroachDB {{ v.major_version }} is partially supported. Pre-LTS patches (before v{{ v.initial_lts_patch }}) are no longer supported, but LTS patches (v{{ v.initial_lts_patch }} and later) are still covered under the LTS support policy until {{ v.lts_asst_supp_exp_date }}. |
…supported page when a version reaches its unsupported date
florence-crl
approved these changes
Mar 7, 2025
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
LGTM
Please create a fast follow-up issue for the following:
I noticed that for the Source filter on Unsupported Versions page it says "No longer available for download." I think for Source it should still have the "View on Github" link.
mohini-crl
dismissed
taroface’s stale review
As Ryan is not present! Asked Florence to review it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.