Skip to content

release-22.1: roachtest: allow TC_BUILDTYPE_ID to be accessible by Docker#96301

Merged
smg260 merged 1 commit intocockroachdb:release-22.1from
smg260:backport22.1-81579
Feb 3, 2023
Merged

release-22.1: roachtest: allow TC_BUILDTYPE_ID to be accessible by Docker#96301
smg260 merged 1 commit intocockroachdb:release-22.1from
smg260:backport22.1-81579

Conversation

@smg260
Copy link
Copy Markdown
Contributor

@smg260 smg260 commented Jan 31, 2023

Backport 1/1 commits from #81579.

/cc @cockroachdb/release


In #81103, the process of generating TeamCity links in test failure
reports started relying on the TC_BUILDTYPE_ID environment
variable. While that variable was added to TeamCity builds, it was not
being passed down to Docker where the tests actually run. As a result,
links generated by the GitHub poster were broken (see, for example, #81572).

This commit makes TC_BUILDTYPE_ID accessible by Docker for every
build that was already passing TC_BUILD_BRANCH. This should be
sufficient to cover all existing cases and more, in case having
access to this variable becomes useful in the future.

Epic: None
Release note: None
Release justification: test only change

@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Jan 31, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@smg260 smg260 marked this pull request as ready for review January 31, 2023 20:31
@smg260 smg260 requested a review from a team as a code owner January 31, 2023 20:31
Copy link
Copy Markdown

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thank you!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @srosenberg)

In cockroachdb#81103, the process of generating TeamCity links in test failure
reports started relying on the `TC_BUILDTYPE_ID` environment
variable. While that variable was added to TeamCity builds, it was not
being passed down to Docker where the tests actually run. As a result,
links generated by the GitHub poster were broken (see, for example, cockroachdb#81572).

This commit makes `TC_BUILDTYPE_ID` accessible by Docker for every
build that was already passing `TC_BUILD_BRANCH`. This should be
sufficient to cover all existing cases and more, in case having
access to this variable becomes useful in the future.

Release note: None
@smg260 smg260 force-pushed the backport22.1-81579 branch from bd0fa60 to fe0d719 Compare February 2, 2023 22:46
@smg260 smg260 merged commit e18a567 into cockroachdb:release-22.1 Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants