roachtest: Make ssh debug logging optional.#95762
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 25, 2023
Merged
roachtest: Make ssh debug logging optional.#95762craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
smg260
force-pushed
the
roachtest_optional_ssh_debug
branch
2 times, most recently
from
e7ea090 to
84f4209
Compare
Wait commands are issued every 500ms returning a non zero exit code until nodes have started. This results in a large number of ssh debug logs during cluster creation. Also adopts functional options. Release note: None Epic: none
smg260
force-pushed
the
roachtest_optional_ssh_debug
branch
from
84f4209 to
fc0d3a2
Compare
smg260
requested review from
renatolabs and
srosenberg
and removed request for
a team
renatolabs
approved these changes
Jan 24, 2023
renatolabs
left a comment
renatolabs
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @srosenberg)
srosenberg
approved these changes
Jan 24, 2023
Contributor
Author
|
bors r=renatolabs,srosenberg |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait commands are issued every 500ms returning a non zero exit code until nodes have started.
This results in a large number of ssh debug logs during cluster creation. Also adopts functional options.
Release note: None
Epic: none