Skip to content

roachtest: fix zipping of artifacts to include other zips#95374

Closed
smg260 wants to merge 2 commits intocockroachdb:release-22.1from
smg260:backport22.1-83923-84085-87304-88716-88556-88492-90720-90451-92082
Closed

roachtest: fix zipping of artifacts to include other zips#95374
smg260 wants to merge 2 commits intocockroachdb:release-22.1from
smg260:backport22.1-83923-84085-87304-88716-88556-88492-90720-90451-92082

Conversation

@smg260
Copy link
Copy Markdown
Contributor

@smg260 smg260 commented Jan 17, 2023

When artifacts are zipped in preparation for being published to
TeamCity, other zip files are skipped. The idea is that we won't try
to recursively zip artifacts.zip itself, or debug.zip, which is
published separately. However, some tests (notably, tpchvec)
download their own zip files in the logs directory so that they'll
be available for analysis when a test fails.

While there was an intention to skip only top-level zip files (as
indicated by existing comments), the code itself would skip any zip
files found in the logs directory. This commit updates the zipping
logic to skip only toplevel zip files, allowing tests to write their
own zip files to the logs directory and have them available for
inspection later.

Release note: None.Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Renato Costa and others added 2 commits January 17, 2023 13:42
When artifacts are zipped in preparation for being published to
TeamCity, other zip files are skipped. The idea is that we won't try
to recursively zip artifacts.zip itself, or debug.zip, which is
published separately. However, some tests (notably, `tpchvec`)
download their own zip files in the `logs` directory so that they'll
be available for analysis when a test fails.

While there was an intention to skip only top-level zip files (as
indicated by existing comments), the code itself would skip any zip
files found in the `logs` directory. This commit updates the zipping
logic to skip only toplevel zip files, allowing tests to write their
own zip files to the `logs` directory and have them available for
inspection later.

Release note: None.
…orted.

Some runtime values are probabilistically set or otherwise have
defaults which are not evident at the time we report issues.

This change returns the vm options associated with a created cluster,
from which we can extract the final computed values for such fields
including the type of filesystem and whether encryption is enabled.

Release justification: test-only change
Release note: none
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@smg260 smg260 closed this Jan 17, 2023
@smg260 smg260 deleted the backport22.1-83923-84085-87304-88716-88556-88492-90720-90451-92082 branch January 17, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants