Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add advertise-host flag to start command #9503

Merged
merged 1 commit into from
Sep 27, 2016

Commits on Sep 27, 2016

  1. cli: Add advertise-host flag to start command

    Enables overriding the interface(s) that the server is listening on
    for the purposes of picking an address to advertise via the gossip
    network.
    
    Could reasonably be expanded with advertise-port if anyone hits a case
    where port forwarding causes issues (could potentially happen in some
    docker deployments).
    
    For what it's worth, it's a little weird that we have `--host` and
    `--port` to contrast with `--http-addr` and `--http-port`. Should we
    try to phase out `--http-addr` and replace it with `--http-host`?
    a-robinson committed Sep 27, 2016
    Configuration menu
    Copy the full SHA
    8bb3226 View commit details
    Browse the repository at this point in the history