roachtest: misc fixes#94361
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Dec 29, 2022
Merged
Conversation
Epic: none Release note: None
tbg
requested review from
erikgrinaker,
herkolategan and
renatolabs
and removed request for
a team
Member
|
This change is |
Fixes cockroachdb#94204. Epic: none Release note: None
Errors were reported like this: > (test_impl.go:291).Fatal: pq: invalid syntax @1 but that line is the impl of `Fatal`. We want to walk up one more frame. Epic: none Release note: None
erikgrinaker
approved these changes
Dec 28, 2022
Member
Author
|
bors r=erikgrinaker |
Contributor
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
srosenberg
approved these changes
Dec 29, 2022
Member
srosenberg
left a comment
srosenberg
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)
Contributor
|
Re-borsing after bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94272.
Fixes #94266.
Epic: none
Release note: None