-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: prevent null-rejection rule cycle #91561
Conversation
This patch adds checks to the null-rejection logic to ensure that null-rejection is not attempted when the necessary filter push-down rules are disabled. This prevents rule cycles that occur when decorrelation or filter elimination rules fire after the `col IS NOT NULL` filter isn't pushed all the way down to the outer join. Fixes cockroachdb#89986 Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
TFTR! |
bors r+ |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from caa50f5 to blathers/backport-release-22.1-91561: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
The machinery for preventing null-rejection when corresponding rules are disabled doesn't exist in 22.1. |
This patch adds checks to the null-rejection logic to ensure that null-rejection is not attempted when the necessary filter push-down rules are disabled. This prevents rule cycles that occur when decorrelation or filter elimination rules fire after the
col IS NOT NULL
filter isn't pushed all the way down to the outer join.Fixes #89986
Release note: None