Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: prevent null-rejection rule cycle #91561

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

DrewKimball
Copy link
Collaborator

This patch adds checks to the null-rejection logic to ensure that null-rejection is not attempted when the necessary filter push-down rules are disabled. This prevents rule cycles that occur when decorrelation or filter elimination rules fire after the col IS NOT NULL filter isn't pushed all the way down to the outer join.

Fixes #89986

Release note: None

This patch adds checks to the null-rejection logic to ensure that
null-rejection is not attempted when the necessary filter push-down rules
are disabled. This prevents rule cycles that occur when decorrelation or
filter elimination rules fire after the `col IS NOT NULL` filter isn't
pushed all the way down to the outer join.

Fixes cockroachdb#89986

Release note: None
@DrewKimball DrewKimball requested a review from a team as a code owner November 8, 2022 23:33
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)

@DrewKimball
Copy link
Collaborator Author

TFTR!

@DrewKimball
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 10, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 10, 2022

Build succeeded:

@craig craig bot merged commit 9e98e4a into cockroachdb:master Nov 10, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 10, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from caa50f5 to blathers/backport-release-22.1-91561: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@DrewKimball
Copy link
Collaborator Author

The machinery for preventing null-rejection when corresponding rules are disabled doesn't exist in 22.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unoptimized-query-oracle: infinite recursion in optimizer
3 participants