Skip to content

release-22.2: ui: fix undefined table stats#89931

Merged
maryliag merged 1 commit intorelease-22.2from
blathers/backport-release-22.2-89867
Oct 13, 2022
Merged

release-22.2: ui: fix undefined table stats#89931
maryliag merged 1 commit intorelease-22.2from
blathers/backport-release-22.2-89867

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl Bot commented Oct 13, 2022

Backport 1/1 commits from #89867 on behalf of @maryliag.

/cc @cockroachdb/release


Previously, if no value was being passed as totalCount, the table stats were showing an "undefined value". This commit as a default value as 0 for the total.

Fixes #89869

Before
Screen Shot 2022-10-11 at 8 43 04 PM

After
Screen Shot 2022-10-12 at 5 21 52 PM

Release note (bug fix): show correct value on table stats on UI, when there is no values to show.


Release justification: bug fix

Previously, if no value was being passed as totalCount,
the table stats were showing an "undefined value". This
commit as a default value as 0 for the total.

Fixes #89869

Release note (bug fix): show correct value on table
stats on UI, when there is no values to show.
@blathers-crl blathers-crl Bot force-pushed the blathers/backport-release-22.2-89867 branch from e8ee316 to a00b12c Compare October 13, 2022 19:56
@blathers-crl blathers-crl Bot requested review from j82w and matthewtodd October 13, 2022 19:56
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl Bot commented Oct 13, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 13, 2022
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@maryliag maryliag requested a review from a team October 13, 2022 20:08
@maryliag maryliag merged commit 40d4794 into release-22.2 Oct 13, 2022
@maryliag maryliag deleted the blathers/backport-release-22.2-89867 branch October 13, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants