upgrades: skip known userfile-related corruption in desc validation#88878
Conversation
ajwerner
left a comment
There was a problem hiding this comment.
This is good, thanks for doing it!
Reviewed 5 of 5 files at r1, 4 of 8 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @adityamaru and @ajwerner)
d1a3c55 to
8659628
Compare
|
bors r=ajwerner |
|
Should we add a userfile step to the mixed version roachtests? |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
I think there is a merge skew with #88875, and it looks like the batch with that PR has smaller number and should go in sooner, so this will need to be rebased. bors r- |
|
Canceled. |
|
@yuzefovich Thanks |
8659628 to
73dab2d
Compare
The related job for this FK constraint was never created because of a userfile error. This migration removes the constraint since it is not currently needed. Release justification: Avoid having a failed upgrade for every user of userfile. Release note (bug fix): Fixes tables created by userfile storage that have invalid foreign key constraints.
73dab2d to
aaaea8b
Compare
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from aaaea8b to blathers/backport-release-22.2-88878: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from aaaea8b to blathers/backport-release-22.2.0-88878: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.0 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
In previous releases, userfiles would create broken tables because
of incorrect use of the internal executor. As a result, any user that
has used userfile, would fail the 22.2 upgrade precondition check.
This does 2 things:
1 allows the precondition to pass even in the presence of an invalid
object as long as that object is very likely the userfile payload table.
Adds a new migration that removes the foreign key mutation for userfile
payload tables.
We determine whether something is a "userfile payload table" by checking
its name, the column names, the column types, the name of the referenced table,
the column names of the referenced table, and the column types of the referenced table.
Release justification: Avoid having a failed upgrade for every user of
userfile.