roachtest: fix pgjdbc and typeorm#81552
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom May 20, 2022
Merged
Conversation
More tests pass now that we support ALTER SEQUENCE ... RESTART Release note: None
Release note: None
Member
|
This change is |
otan
approved these changes
May 20, 2022
Contributor
otan
left a comment
otan
left a comment
There was a problem hiding this comment.
the typeorm situation is quite sad :(
Collaborator
Author
|
yeah :/ it seems like typeorm actually already has retry logic for txns: https://github.com/typeorm/typeorm/blob/189592c77980e766f92f6eb77dbd7412db106086/src/driver/cockroachdb/CockroachQueryRunner.ts#L187 but i guess it can't kick in for some commands? bors r=otan |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #81515
fixes #81431
See individual commits.