cli: bump the cobra dependency and add autocompletion for fish #63839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20210419-cobra
branch
2 times, most recently
from
ac7543a to
8378a27
Compare
stevendanna
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @knz and @otan)
a discussion (no related file):
Looks reasonable to me. I wonder if upstream would take an option to disable the automatic generation of options. But, until they do, the workaround looks reaosnable.
This updates the cobra dep which hadn't been updated since 2017. Also picks up the new support for fish autocompletions. Release note (cli change): Certain errors caused by invalid command-line arguments are now printed on the process' standard error stream, instead of standard output. Release note (cli change): The `cockroach gen autocomplete` command has been updated and can now produce autocompletion definitions for the `fish` shell.
|
TFYR! bors r=stevendanna |
1 similar comment
|
TFYR! bors r=stevendanna |
|
Already running a review |
|
Build succeeded: |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63838 .
Fixes #50187.
This updates the cobra dep which hadn't been updated since 2017.
Also picks up the new support for fish autocompletions.
Release note (cli change): Certain errors caused by invalid
command-line arguments are now printed on the process' standard
error stream, instead of standard output.
Release note (cli change): The
cockroach gen autocompletecommandhas been updated and can now produce autocompletion definitions
for the
fishshell.