roachtest: fix artifacts publishing on TeamCity #31552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifacts publishing broke recently when the way artifacts dirs started being explicitly plumbed around. Before this patch, the wrong path was being indicated to TC because test name was doubly-represented; it was there both in the artifactsDir var and then we appended it again. Release note: None
|
This change is |
jordanlewis
approved these changes
Oct 17, 2018
|
bors r+ |
|
Thanks @andreimatei! |
Build failed |
|
known flake
bors r+
…On Wed, Oct 17, 2018 at 2:49 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=972241&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31552 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBccrAU0aDgllYIqaN1yCtbCH4MbWoks5ul3ulgaJpZM4Xk40a>
.
|
craig bot
pushed a commit
that referenced
this pull request
Oct 17, 2018
31552: roachtest: fix artifacts publishing on TeamCity r=andreimatei a=andreimatei Artifacts publishing broke recently when the way artifacts dirs started being explicitly plumbed around. Before this patch, the wrong path was being indicated to TC because test name was doubly-represented; it was there both in the artifactsDir var and then we appended it again. Release note: None 31553: *: update to apd v2.0.0 r=mjibson a=mjibson There was a breaking API change but it's now much safer to use. Release note: None Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Matt Jibson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artifacts publishing broke recently when the way artifacts dirs started
being explicitly plumbed around. Before this patch, the wrong path was
being indicated to TC because test name was doubly-represented; it was
there both in the artifactsDir var and then we appended it again.
Release note: None