Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport-2.0: storage: return one entry less in Entries #31351

Merged
merged 1 commit into from
Oct 15, 2018

Commits on Oct 15, 2018

  1. storage: return one entry less in Entries

    This works around the bug outlined in:
    
    etcd-io/etcd#10063
    
    by matching Raft's internal implementation of commit pagination.
    Once the above PR lands, we can revert this commit (but I assume
    that it will take a little bit), and I think we should do that
    because the code hasn't gotten any nicer to look at.
    
    Fixes cockroachdb#28918.
    
    Release note: None
    
    #
    # Commit message recommendations:
    #
    #     ---
    #     <pkg>: <short description>
    #
    #     <long description>
    #
    #     Release note (category): <release note description>
    #     ---
    #
    # Wrap long lines! 72 columns is best.
    #
    # The release note must be present if your commit has
    # user-facing changes. Leave the default above if not.
    #
    # Categories for release notes:
    # - cli change
    # - sql change
    # - admin ui change
    # - general change (e.g., change of required Go version)
    # - build change (e.g., compatibility with older CPUs)
    # - enterprise change (e.g., change to backup/restore)
    # - backwards-incompatible change
    # - performance improvement
    # - bug fix
    #
    # Commit message recommendations:
    #
    #     ---
    #     <pkg>: <short description>
    #
    #     <long description>
    #
    #     Release note (category): <release note description>
    #     ---
    #
    # Wrap long lines! 72 columns is best.
    #
    # The release note must be present if your commit has
    # user-facing changes. Leave the default above if not.
    #
    # Categories for release notes:
    # - cli change
    # - sql change
    # - admin ui change
    # - general change (e.g., change of required Go version)
    # - build change (e.g., compatibility with older CPUs)
    # - enterprise change (e.g., change to backup/restore)
    # - backwards-incompatible change
    # - performance improvement
    # - bug fix
    tbg committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    2536910 View commit details
    Browse the repository at this point in the history