-
Notifications
You must be signed in to change notification settings - Fork 4k
ui: rework the storage dashboard #158015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ui: rework the storage dashboard #158015
+260
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the file descriptor and time series graphs to the bottom of the storage dashboard. These graphs are relatively niche and less useful than the other graphs within the dashboard. Epic: none Release note: none
Previously the storage dashboard had two separate graphs for log-commit latencies (p99 and p50) and two separate graphs for command-commit latencies (p99 and p50). This commit consolidates these four graphs into two: one for log-commit latencies and one for command-commit latencies. Epic: none Release note: none
Add two missing I/O write categories to the storage dashboard's 'Disk Write Breakdown' graph: pebble-manifest and pebble-blob-file-rewrite. Epic: none Release note: none
Add a new graph to the storage dashboard within the DB Console, graphing block bytes loaded by iterators per category. Epic: none Informs cockroachdb#156391. Release note: none
When focused on a single node, some DB console graphs show per-store metrics with an additional graph aggregating across the node's stores. In the common case of a single-store node, the aggregated metric and the per-store metric are the same and make the graph more difficult to parse. This commit updates these graphs to only include the aggregated metric if a node has more than one store. Epic: none Release note: none
Extend the storage dashboard to include value separation metrics. For now this includes referenced and unreferenced value byte totals and the sum of the size of all blob files. Informs cockroachdb#156391. Epic: none Release note: none
Member
RaduBerinde
approved these changes
Nov 18, 2025
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jasonlmfong and @xinhaoz)
Adapt the storage dashboard graph that displays the count of sstables in a store to also show the number of blob files. Epic: none Release note: none
60e680c to
ade6ef0
Compare
Collaborator
Author
|
TFTR! bors r=RaduBerinde |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the storage dashboard within the DB console to consolidate some graphs and extend the dashboard with additional observability introduced in recent releases.
Close #156391.