Skip to content

Conversation

@rickystewart
Copy link
Collaborator

Backport 1/1 commits from #157847.

/cc @cockroachdb/release

Release justification: Non-production code changes


Re-apply 9fecc53b0b3cde307b5379ee5b88fae0fc8f34e2, but add a skip if the test is running under s390x.

Release note: none
Epic: none

@rickystewart rickystewart requested a review from a team as a code owner November 17, 2025 23:01
@blathers-crl
Copy link

blathers-crl bot commented Nov 17, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-code-systems labels Nov 17, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl
Copy link

blathers-crl bot commented Nov 17, 2025

✅ PR #157958 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR qualifies for an exception due to the inclusion of a release justification statement and changes to non-production files focused on testing. Specifically, the PR body includes a 'Release justification: Non-production code changes' line, indicating that the changes should not affect production code and thereby exempt from the strict backport policy. The files changed are within the pkg/bench/rttanalysis/ directory, which is related to benchmark tests and not part of the production deployment. These files pertain to modifications and improvements in testing, particularly affecting the benchmark testing of the project.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Re-apply `9fecc53b0b3cde307b5379ee5b88fae0fc8f34e2`, but add a `skip` if
the test is running under `s390x`.

Release note: none
Epic: none
@rickystewart rickystewart merged commit 2ec926e into cockroachdb:release-24.3 Nov 18, 2025
16 checks passed
@rickystewart rickystewart deleted the backport24.3-157847 branch November 18, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-code-systems target-release-24.3.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants