*: standardize pprof labeling code #157940
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
pav-kv
reviewed
Nov 17, 2025
pav-kv
reviewed
Nov 17, 2025
This commit replaces usages of `pprof.Do` with our internal implementation that wraps the `SetProfilerLabels` utility. This enables us to have better standardization around profiler label application and easier tracking of all usages. A linter is added to enforce this usage. Epic: CRDB-55080 Part of: CRDB-55923 Release note: None
dhartunian
force-pushed
the
davidh/pprof-label-refactor
branch
from
62ded38 to
6dbcf08
Compare
pav-kv
approved these changes
Nov 20, 2025
Comment on lines
+1166
to
+1168
| if err != nil { | ||
| t.Fatal(err) | ||
| } |
Collaborator
There was a problem hiding this comment.
use require?
require.NoError(t, err)
require.NoError(t, cmd.Start())
// etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces usages of
pprof.Dowith our internalimplementation that wraps the
SetProfilerLabelsutility. Thisenables us to have better standardization around profiler label
application and easier tracking of all usages.
A linter is added to enforce this usage.
Epic: CRDB-55080
Part of: CRDB-55923
Release note: None