mmaprototype: represent pure lease transfers via ChangeReplica #157821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: CRDB-55052
Because we don't want to refer to a store multiple times in a slice of pending changes, promotions and demotions could already "wrap" a lease transfer. In this commit, we make this the only way to represent a lease transfer, and remove the explicit AddLease and RemoveLease operations. This removes ambiguity, and makes the code more approachable. The downside to this change is that one needs to inspect the particular change to determine whether it requires a replication change (or only a lease transfer). But this strikes me as a worthwhile trade-off. Informs cockroachdb#157757. Epic: CRDB-55052
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Member
Author
|
@sumeerbhola noted on #157118:
I still need to look into this. |
Member
Author
|
I'll put this on hold for now, there is a lot of activity in that part of the codebase right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from here.
In this commit, we make this the only way to represent a lease transfer, and
remove the explicit AddLease and RemoveLease operations. This removes ambiguity,
and makes the code more approachable.
The downside to this change is that one needs to inspect the particular change
to determine whether it requires a replication change (or only a lease
transfer). But this strikes me as a worthwhile trade-off.
Informs #157757.
Epic: CRDB-55052