Skip to content

Conversation

@rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 3, 2025

Backport 1/1 commits from #156692 on behalf of @rafiss.


This library does not support FIPS.

fixes #156439
Release note: None


Release justification:

This library does not support FIPS.

Release note: None
@rafiss rafiss force-pushed the blathers/backport-release-25.2-156692 branch from 67a2d55 to 3ae1918 Compare November 3, 2025 16:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 3, 2025
@blathers-crl blathers-crl bot requested review from bghal and spilchen November 3, 2025 16:34
@blathers-crl
Copy link

blathers-crl bot commented Nov 3, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 3, 2025
@blathers-crl
Copy link

blathers-crl bot commented Nov 3, 2025

✅ PR #156783 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request involves changes only to a file recognized as non-production code under the backport policy. The modified file (pkg/cmd/roachtest/tests/nodejs_postgres.go) falls within the pkg/cmd/roachtest/ path, which is explicitly listed as pertaining to development tools in the policy. Thus, this PR is exempt from the critical bug or feature flag requirements typically necessary for backport compliance.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator Author

rafiss commented Nov 3, 2025

this branch doesn't have the "except FIPS" spec

nogo: nogo: error running analyzers: 44 analyzers skipped due to type-checking error: pkg/cmd/roachtest/tests/nodejs_postgres.go:180:57: undefined: spec.AllExceptFIPS

@rafiss rafiss closed this Nov 3, 2025
@rafiss rafiss deleted the blathers/backport-release-25.2-156692 branch November 16, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-failed blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants