Skip to content

Conversation

@blathers-crl
Copy link

@blathers-crl blathers-crl bot commented Sep 29, 2025

Backport 1/1 commits from #151946 on behalf of @ZhouXing19.


Previously, only metrics for executed SELECT|UPDATE|DELETE|INSERT statements are labeled, while their started equivalent are not labeled. This commit is to label these metrics. Since they are not frequently used metrics, they are not marked as Essential.

Fixes: #152074

Release note (ops change): sql.select.started.count, sql.insert.started.count, sql.update.started.count, sql.delete.started.count are now labeled with sql.started.count.


Release justification: low-risk improvement to observability.

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.4-151946 branch from 46f2746 to d9fd0ca Compare September 29, 2025 18:20
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 29, 2025
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 29, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Sep 29, 2025
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 29, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzefovich reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @dhartunian and @ZhouXing19)


-- commits line 12 at r1:
nit: leftover.

Previously, only metrics for *executed* `SELECT|UPDATE|DELETE|INSERT`
statements are labeled, while their *started* equivalent are not labeled.
This commit is to label these metrics.

Ref #143536

Release note (ops change): sql.select.started.count, sql.insert.started.count, sql.update.started.count, sql.delete.started.count are now labeled with sql.started.count.
@ZhouXing19 ZhouXing19 force-pushed the blathers/backport-release-25.4-151946 branch from d9fd0ca to 357db91 Compare September 29, 2025 19:16
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Justification: low-risk configuration change to metric naming. New endpoint with labels does not have stable API yet.

@ZhouXing19 ZhouXing19 merged commit 121d175 into release-25.4 Oct 2, 2025
15 checks passed
@ZhouXing19 ZhouXing19 deleted the blathers/backport-release-25.4-151946 branch October 2, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-queries SQL Queries Team v25.4.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants