sql/inspect: convert internal errors to inspect issues #152984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
spilchen
force-pushed
the
gh-148299/250904/1024/inspect-internal-err/pr-ready
branch
from
d3c86fa to
e1c05a2
Compare
Previously, internal errors during index consistency checks would fail the entire job. Now these errors are converted to structured inspect issues with detailed context. Closes cockroachdb#148299 Release note: none Epic: None
spilchen
force-pushed
the
gh-148299/250904/1024/inspect-internal-err/pr-ready
branch
from
e1c05a2 to
ed8c021
Compare
fqazi
approved these changes
Sep 4, 2025
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @spilchen)
Contributor
Author
|
TFTR! bors r+ |
Contributor
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, internal errors during index consistency checks would fail the entire job. Now these errors are converted to structured inspect issues with detailed context.
Closes #148299
Release Notes: None
Epic: None