Skip to content

kvserver: add onProcessResult and onEnqueueResult to processCallback #152792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craig merged 9 commits into from
Sep 3, 2025
Merged

kvserver: add onProcessResult and onEnqueueResult to processCallback #152792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fa26dc3
kvserver: use non-blocking send on errors for maybeBackpressureBatch
wenyihu6 Aug 31, 2025
8b3cc69
kvserver: return baseQueueAsyncRateLimited from bq.Async
wenyihu6 Aug 29, 2025
b2fdcb8
kvserver: add onProcessResult and onEnqueueResult to processCallback
wenyihu6 Aug 28, 2025
2561173
kvserver: add TestBaseQueueCallback
wenyihu6 Aug 30, 2025
2e20ab6
kvserver: better comments for on processCallback
wenyihu6 Sep 2, 2025
499aefd
kvserver: treat priority update as a success with onEnqueueResult
wenyihu6 Sep 2, 2025
f54cc67
kvserver: rename processCallback processCallback to cb processCallback
wenyihu6 Sep 2, 2025
ad60270
kvserver: call cb.onEnqueueResult in defer on errors
wenyihu6 Sep 2, 2025
a5d7d88
fixup! kvserver: treat priority update as a success with onEnqueueResult
wenyihu6 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kv/kvserver/mvcc_gc_queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,7 +878,7 @@ func (mgcq *mvccGCQueue) scanReplicasForHiPriGCHints(
if !isLeaseHolder {
return true
}
added, _ := mgcq.addInternal(ctx, desc, replica.ReplicaID(), deleteRangePriority)
added, _ := mgcq.addInternal(ctx, desc, replica.ReplicaID(), deleteRangePriority, noopProcessCallback)
if added {
mgcq.store.metrics.GCEnqueueHighPriority.Inc(1)
foundReplicas++
Expand Down
Loading