Skip to content

Conversation

@shubhamdhama
Copy link
Contributor

@shubhamdhama shubhamdhama commented Jul 9, 2025

In cockroachdb/drpc#10, we added the DRPC framework level support for interceptors. This PR ports the metrics interceptor to DRPC server.

Epic: CRDB-49359
Release note: None
Fixes: #144373

In cockroachdb/drpc#10, we added the DRPC framework level support for
interceptors. This PR ports the metrics interceptor to DRPC server.

Epic: CRDB-49359
Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Jul 9, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@shubhamdhama
Copy link
Contributor Author

shubhamdhama commented Jul 9, 2025

Couple of improvements are needed here,

  1. Decide whether we really need a separate metric for DRPC. The other options here are: Reuse the existing metric and add another dimension rpcServer with two possible values drpc and grpc. Or, neither of them, reuse the same metric as it is.
  2. Deduplication of code

@shubhamdhama
Copy link
Contributor Author

Closing in favor of #153651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server: implement metrics, filtering rules on server state interceptors in drpc

2 participants