roachtest: wait for propagation of tenant cluster settings #137843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#137503. This commit updates the setTenantSetting utility to wait for the propagation of the tenant cluster settings to each SQL gateway before returning. This avoids races where the tenant cluster settings are not yet propagated to the SQL gateway when the test randomly chooses a gateway and tries to use it. Release note: None
nvanbenschoten
added
backport-24.1.x
|
This change is |
tbg
approved these changes
Dec 23, 2024
|
TFTR! bors r=tbg |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #137503: branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137503.
This commit updates the setTenantSetting utility to wait for the propagation of the tenant cluster settings to each SQL gateway before returning. This avoids races where the tenant cluster settings are not yet propagated to the SQL gateway when the test randomly chooses a gateway and tries to use it.
Release note: None