roachtest: remove kv100 from cdc bench tests #135922
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rharding6373
requested review from
herkolategan and
nameisbhaskar
and removed request for
a team
|
This change is |
asg0451
approved these changes
Nov 21, 2024
Historically CDC has benchmarked changefeeds with the kv100 read-only workload to determine the impact of changefeeds when there is no data watched. Due to the roachtest's flakiness, we're not getting much value out of continuing to benchmark this. This PR removes kv100 from the regularly run benchmark, but leaves the infrastructure in place so that it can be run in the future if desired. Epic: none Release note: none
rharding6373
force-pushed
the
20241121_cdcbench
branch
from
8edd49c
to
2683816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically CDC has benchmarked changefeeds with the kv100 read-only workload to determine the impact of changefeeds when there is no data watched. Due to the roachtest's flakiness, we're not getting much value out of continuing to benchmark this. This PR removes kv100 from the regularly run benchmark, but leaves the infrastructure in place so that it can be run in the future if desired.
Epic: none
Release note: none