Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: remove multiregion leasing benchmark #135911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Nov 21, 2024

Previously, we added a benchmark comparing session based leasing against expiry based leasing for SQL. Since expiry based leasing is no longer and will be delete we are going to remove this benchmark.

Fixes: #130291

Release note: None

Previously, we added a benchmark comparing session based leasing against
expiry based leasing for SQL. Since expiry based leasing is no longer
and will be delete we are going to remove this benchmark.

Fixes: cockroachdb#130291

Release note: None
@fqazi fqazi requested a review from a team November 21, 2024 15:22
@fqazi fqazi requested a review from a team as a code owner November 21, 2024 15:22
@fqazi fqazi requested review from nameisbhaskar and vidit-bhat and removed request for a team November 21, 2024 15:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss added backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3 labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2 backport-24.3.x Flags PRs that need to be backported to 24.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: schemachange/leasing-benchmark failed
3 participants