roachtest: ignore flaky activerecord tests #135907
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annrpom
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
This change is |
rafiss
requested changes
Nov 21, 2024
There was a problem hiding this comment.
i just assigned #135801 to you as well, would you be able to add that test too if it's not too much trouble?
so the full list of tests to ignore:
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not
TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_are_translated_to_specific_exception_with_validate_false
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_on_insert_are_translated_to_specific_exception
CockroachDB::AdapterForeignKeyTest#test_foreign_key_violations_on_delete_are_translated_to_specific_exception
BasicsTest#test_default_values_are_deeply_dupped
| `PostGISTest#test_point_to_json`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "unknown", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "unknown", |
There was a problem hiding this comment.
nit: these new tests are flaky, so should be in the ignoreList.
(right now they are in the blockList, which means the test will expect them to fail every time.)
|
hm, actually the |
annrpom
force-pushed
the
deflake-activerecord
branch
from
e00b052
to
7293fd0
Compare
ok i'll keep my eye out for those! |
rafiss
requested changes
Nov 21, 2024
| `ActiveRecord::ConnectionAdapters::PostgreSQLAdapterTest#test_translate_no_connection_exception_to_not_established`: "pg_terminate_backend not implemented", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_save_and_return_false_if_a_callback_cancelled_saving_in_either_create_or_update`: "flaky", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_not_update_children_when_parent_creation_with_no_reason`: "flaky", | ||
| `TestAutosaveAssociationOnAHasAndBelongsToManyAssociation#test_should_update_children_when_autosave_is_true_and_parent_is_new_but_child_is_not`: "flaky", |
There was a problem hiding this comment.
can we add BasicsTest#test_default_values_are_deeply_dupped?
There was a problem hiding this comment.
my reading comprehension skills were afoot
Fixes: cockroachdb#134811 Fixes: cockroachdb#135801 Release note: None
annrpom
force-pushed
the
deflake-activerecord
branch
from
7293fd0
to
41d59df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #134811
Fixes: #135801
Release note: None