Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump Pebble to 030afd266b2d #132794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Oct 16, 2024

Note this commit includes manual changes to use the new KeySchema configuration API.

Changes:

  • 030afd26 colblk: use UnsafeOffsets.At2 in another instance
  • b3993ff6 db: persist Experimental.EnableColumnarBlocks in OPTIONS file
  • c719c4e5 db: support multiple KeySchemas

Release note: none.
Epic: none.

Changes:

 * [`030afd26`](cockroachdb/pebble@030afd26) colblk: use UnsafeOffsets.At2 in another instance
 * [`b3993ff6`](cockroachdb/pebble@b3993ff6) db: persist Experimental.EnableColumnarBlocks in OPTIONS file
 * [`c719c4e5`](cockroachdb/pebble@c719c4e5) db: support multiple KeySchemas

Release note: none.
Epic: none.
@jbowens jbowens requested review from a team as code owners October 16, 2024 22:03
Copy link

blathers-crl bot commented Oct 16, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens
Copy link
Collaborator Author

jbowens commented Oct 17, 2024

The MVCC metamorphic tests failed 😬

@RaduBerinde
Copy link
Member

I don't get it, we're not even enabling the new format.. I looked at the code around opts.Experimental.EnableColumnarBlocks again and it seems fine..

@RaduBerinde
Copy link
Member

They pass with this patch to options.go:

                        case "comparer":
-                               o.Comparer, err = parseComparer(value)
+                               var comparer *Comparer
+                               comparer, err = parseComparer(value)
+                               if comparer != nil {
+                                       o.Comparer = comparer
+                               }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants