cluster-ui: add context to provide tenant status to db pages #132770
Merged
+203
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
force-pushed
the
add-tenant-context
branch
2 times, most recently
from
2862dd4
to
67d5563
Compare
kyle-a-wong
approved these changes
Oct 16, 2024
Cluster UI now exports a context to be used to fill in whether or not the cluster is a tenant. This is to support the existing behaviour on the old db pages where we hide the node/region column for tenant clusters. The useHistory import in useTable is also changed to import from react-router-dom which interfaces directly with the browser's history, instead of a context object. This fixes an error when importing components that use this hook in CC, since useHistory from react-router expects a Router parent in the tree from the same package version. This commit also bumps the cluster-ui pkg version for publish. Epic: none Release note: None
xinhaoz
force-pushed
the
add-tenant-context
branch
from
67d5563
to
6cdb970
Compare
|
tftr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster UI now exports a context to be used to fill in whether or not the cluster is a tenant. This is to support the existing behaviour on the old db pages where we hide the node/region column for tenant clusters.
Epic: none
Release note: None