Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add old zone config in zone config logs #132677

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sql: add old zone config in zone config logs #132677

wants to merge 4 commits into from
+262 −302

Commits on Oct 17, 2024

  1. sql: remove enterprise check for subzone rep ctrls 

    With the deprecation of the core license, we no longer need to
an enterprise license check for configuring replication controls
regarding subzones. This patch mainly just performs clean-up -- as
in real servers, we overwrite `base.CheckEnterpriseEnabled` with the
one in `ccl/utilccl/license_check.go`, which always returns true now.

Epic: None

Release note: None
    @annrpom
    annrpom committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    438f539 View commit details
    Browse the repository at this point in the history

  2. sql: add old zone config in zone config logs 

    This patch adds another field in `eventpb.SetZoneConfig`.
This field, `ResolvedOldConfig`, will aid in logging the zone
configuration that we have changed.

We use the `completeZone/completeSubzone` here because we want to
be more useful in our zone config logging. The benefit of using the
complete* is that we can explicitly see what fields are changing,
even if they are actually modeled as a zone config that just inherits
from its parent. The disadvantage of this is that we are not able
to easily tell the inheritence of the old zone config, but knowing
the actual diff between the old vs new config seems more relevant
for debugging.

Fixes: cockroachdb#127176

Release note: None
    @annrpom
    annrpom committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    700790d View commit details
    Browse the repository at this point in the history

  3. schemachanger: log index, partition 

    This patch enables logging for index and partition
zone configs in the DSC.

Release note: None
    @annrpom
    annrpom committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2ce1047 View commit details
    Browse the repository at this point in the history

  4. schemachanger: add old zone config in zone config logs in DSC 

    This patch fills the `ResolvedOldConfig` field in
`eventpb.SetZoneConfig` to log the old zone configuration
in the declarative schema changer.

Informs: cockroachdb#127176

Release note: None
    @annrpom
    annrpom committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    d9bd326 View commit details
    Browse the repository at this point in the history