Skip to content

Conversation

@nvb
Copy link
Contributor

@nvb nvb commented Oct 14, 2024

No patch release of v22.2 and earlier has #114365, so they have the potential to be flaky when evacuating nodes using zone configs. Don't use zone config movement for these versions.

Release note: None

Release justification: test only.

@nvb nvb requested a review from kvoli October 14, 2024 22:33
@nvb nvb requested a review from a team as a code owner October 14, 2024 22:33
@nvb nvb requested review from herkolategan and vidit-bhat and removed request for a team October 14, 2024 22:33
@blathers-crl
Copy link

blathers-crl bot commented Oct 14, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Oct 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nvb nvb force-pushed the nvanbenschoten/changeReplsMixed_23.2 branch from 3c23cb2 to 4904090 Compare October 16, 2024 04:25
Closes cockroachdb#132546.

No patch release of v22.2 and earlier has cockroachdb#114365, so they have the
potential to be flaky when evacuating nodes using zone configs. Don't
use zone config movement for these versions.

Release note: None
@nvb nvb force-pushed the nvanbenschoten/changeReplsMixed_23.2 branch from 4904090 to c6e8922 Compare October 16, 2024 05:54
@nvb nvb merged commit 9646dcd into cockroachdb:release-23.2 Oct 16, 2024
@nvb nvb deleted the nvanbenschoten/changeReplsMixed_23.2 branch October 16, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches v23.2.16

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants