cluster-ui: copy some base components from cloud #130685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinhaoz
requested review from
angles-n-daemons
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
kyle-a-wong
approved these changes
Sep 13, 2024
This commit ports over some basic components from cloud. They are placed in a new directory, `sharedFromCloud` and will be deleted once the new package is ready. This is simply a temporary solution. Componentsported over, with their dependencies: - Search - PageHeader - PageCount (for displaying table pagination) Epic: CRDB-37558 Release note: None
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports over some basic components from cloud. They are
placed in a new directory,
sharedFromCloudand will be deletedonce the new package is ready. This is simply a temporary solution.
Components ported over, with their dependencies:
Epic: CRDB-37558
Release note: None