server: periodically nudge decommissioning repls behind setting #130086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
kvoli
force-pushed
the
240904.enqueue-decommissioning-replicas
branch
2 times, most recently
from
5750d1a to
3b4de5e
Compare
kvoli
force-pushed
the
240904.enqueue-decommissioning-replicas
branch
2 times, most recently
from
a8ea6e2 to
a19a7f9
Compare
When `server.decommissioning.periodic_nudge_interval` is set to a non-zero value, each node will periodically nudge the ranges with a decommissioning replica the node holds a lease for. When there are no ranges remaining on the decommissioning node, which are leased on a node, the nudger will stop. The setting is disabled by default (=0). Resolves: cockroachdb#130085 Release note: None
kvoli
force-pushed
the
240904.enqueue-decommissioning-replicas
branch
from
a19a7f9 to
37ba3fd
Compare
Contributor
Author
|
Closing in favor of #130117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
server.decommissioning.periodic_nudge_intervalis set to a non-zero value, each node will periodically nudge the ranges with a decommissioning replica the node holds a lease for.When there are no ranges remaining on the decommissioning node, which are leased on a node, the nudger will stop.
Resolves: #130085
Release note: None