Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rac2: add AdmittedTracker interface for use by RangeController #130054

Merged
merged 1 commit into from
Sep 4, 2024
Merged

rac2: add AdmittedTracker interface for use by RangeController #130054

merged 1 commit into from
Sep 4, 2024

Conversation

sumeerbhola
Copy link
Collaborator

The AdmittedTracker provides the latest AdmittedVector, and will be implemented by processorImpl.

Informs #129508

Epic: CRDB-37515

Release note: None

@sumeerbhola sumeerbhola requested a review from a team as a code owner September 3, 2024 22:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sumeerbhola
sumeerbhola commented Sep 4, 2024
View reviewed changes
Copy link
Collaborator Author

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)

pkg/kv/kvserver/kvflowcontrol/rac2/range_controller_test.go line 122 at r1 (raw file):

Previously, pav-kv (Pavel Kalinnikov) wrote…

What happens with the priorities != pri when Term goes up? Should we rather pass the whole AdmittedVector in and update it wholesale?

This was probably just a quick convenience in order to be able to provide just an incremental update in the test. I have added a TODO to improve this.

@sumeerbhola
Copy link
Collaborator Author

TFTR!

kvoli
kvoli approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @pav-kv)

pkg/kv/kvserver/kvflowcontrol/rac2/range_controller_test.go line 122 at r1 (raw file):

Previously, sumeerbhola wrote…

This was probably just a quick convenience in order to be able to provide just an incremental update in the test. I have added a TODO to improve this.

It was convenience. We can change it.

@sumeerbhola
rac2: add AdmittedTracker interface for use by RangeController
4cab332 
The AdmittedTracker provides the latest AdmittedVector, and will be
implemented by processorImpl.

Informs cockroachdb#129508

Epic: CRDB-37515

Release note: None
@sumeerbhola
Copy link
Collaborator Author

bors r=pav-kv,kvoli

@craig
Copy link
Contributor

craig bot commented Sep 4, 2024

Build succeeded:

@craig craig bot merged commit 77606cb into cockroachdb:master Sep 4, 2024
23 checks passed
@sumeerbhola sumeerbhola mentioned this pull request Sep 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvoli kvoli kvoli approved these changes

@pav-kv pav-kv Awaiting requested review from pav-kv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumeerbhola @cockroach-teamcity @pav-kv @kvoli