Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser,mt: remove CREATE TENANT ... LIKE #129758

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

dt
Copy link
Member

@dt dt commented Aug 27, 2024

The problem -- needing to apply a large number of configuration knobs -- solved by the 'template tenant' functionality has since been solved instead by having named service modes for each distinct common set of configurations, for example 'shared' which implies all capabilities in addition to in-process service. The template functionality was never pushed on PCR UA users, and is not used in cloud, and thus has no users and is accordingly removed here.

Release note: none.
Epic: none.

@dt dt requested a review from jeffswenson August 27, 2024 21:23
@dt dt requested review from a team as code owners August 27, 2024 21:23
@dt dt requested review from stevendanna and removed request for a team August 27, 2024 21:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dt
Copy link
Member Author

dt commented Aug 29, 2024

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 29, 2024

Build failed:

The problem -- needing to apply a large number of configuration knobs -- solved by the
'template tenant' functionality has since been solved instead by having named service modes
for each distinct common set of configurations, for example 'shared' which implies
all capabilities in addition to in-process service. The template functionality was
never pushed on PCR UA users, and is not used in cloud, and thus has no users and
is accordingly removed here.

Release note: none.
Epic: none.
@dt
Copy link
Member Author

dt commented Sep 4, 2024

bors r+

@craig craig bot merged commit 77606cb into cockroachdb:master Sep 4, 2024
23 checks passed
@dt dt deleted the no-like branch September 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants