Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add --certs-dir, --user to encode-uri, fix dupe scheme printing #126793

Merged
merged 3 commits into from
Jul 8, 2024
Merged

cli: add --certs-dir, --user to encode-uri, fix dupe scheme printing #126793

merged 3 commits into from
Jul 8, 2024

Conversation

dt
Copy link
Member

@dt dt commented Jul 6, 2024

See commits.

@dt dt requested a review from stevendanna July 6, 2024 16:58
@dt dt requested review from a team as code owners July 6, 2024 16:58
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Jul 6, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

dt added 3 commits July 6, 2024 16:58
@dt
cli: fix duplicate scheme in encode-uri
7e87df3 
Previously 'encode-uri postgres://some.url' would return a URI with the
scheme duplicated, since it assumed it was not passed a scheme, however
it is common that it is.

Release note: none.
Epic: none.
@dt
cli: add --user option to encode-uri
896e2f2 
Release note: none.
Epic: none.
@dt
cli: add --certs-dir support to encode-uri
a228887 
Release note (ops change): the encode-uri command now supports the --certs-dir option as an alternative to passing individual cert paths.

Epic: none.
@dt
Copy link
Member Author

dt commented Jul 8, 2024

bors r+

TFTR

@dt dt added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Jul 8, 2024
@craig
Copy link
Contributor

craig bot commented Jul 8, 2024

Build succeeded:

@craig craig bot merged commit a1091c2 into cockroachdb:master Jul 8, 2024
22 checks passed
@blathers-crl blathers-crl bot mentioned this pull request Jul 8, 2024
Open
@dt dt deleted the encode-uri branch July 8, 2024 17:15
@cockroachdb cockroachdb deleted a comment from cockroach-teamcity Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

Assignees
No one assigned
Labels
backport-24.1.x Flags PRs that need to be backported to 24.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dt @stevendanna