Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv-obs: annotate consistency queue graph with explanation #126759

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

lyang24
Copy link
Contributor

@lyang24 lyang24 commented Jul 4, 2024

This commit annotates the consistency queue graph with a hint that explains what the role of the queue is and that a persistent pending backlog is expected and benign.

Fixes: #83869

Release note: None

image

This commit annotates the consistency queue graph with a hint that explains
what the role of the queue is and that a persistent pending backlog is expected
and benign.

Fixes: #cockroachdb#83869

Release note: None
@lyang24 lyang24 requested a review from a team as a code owner July 4, 2024 21:02
@lyang24 lyang24 requested review from kyle-a-wong and removed request for a team July 4, 2024 21:02
Copy link

blathers-crl bot commented Jul 4, 2024

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jul 4, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@kyle-a-wong kyle-a-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyang24 thanks for the PR, this change looks good to me! I've kicked off the workflows that required approval to start.

@kyle-a-wong
Copy link
Contributor

bors r+

@craig craig bot merged commit cc1f931 into cockroachdb:master Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kv-obs: annotate consistency queue graph with explanation
3 participants