sql: fix pg_catalog formatting of BYTES expressions #126697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit fixes a regression introduced in cockroachdb#126297 that caused incorrect formatting of BYTES expressions in pg_catalog. Fixes cockroachdb#126344 There is no release note because this bug is not present in any releases. Release note: None
Release note: None
mgartner
force-pushed
the
126344-fix-pg-catalog-format
branch
from
c8ce706
to
48fa011
Compare
yuzefovich
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
|
TFTR! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: fix pg_catalog formatting of BYTES expressions
This commit fixes a regression introduced in #126297 that caused
incorrect formatting of BYTES expressions in pg_catalog.
Fixes #126344
There is no release note because this bug is not present in any
releases.
Release note: None
sqlsmith: unskip TestGenerateParse
Release note: None