Skip to content

release-23.2: storage: avoid expensive logging in MVCCAcquireLock #115025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvb merged 1 commit into from
Nov 27, 2023
Merged

release-23.2: storage: avoid expensive logging in MVCCAcquireLock #115025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pkg/storage/mvcc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5938,9 +5938,11 @@ func MVCCAcquireLock(
// number, our newer sequence number could then be rolled back and
// we would forget that the lock held at the older sequence number
// had been and still should be held.
log.VEventf(ctx, 3, "skipping lock acquisition for txn %s on key %s "+
"with strength %s; found existing lock with strength %s and sequence %d",
txn, key.String(), str.String(), iterStr.String(), foundLock.Txn.Sequence)
if log.ExpensiveLogEnabled(ctx, 3) {
log.VEventf(ctx, 3, "skipping lock acquisition for txn %s on key %s "+
"with strength %s; found existing lock with strength %s and sequence %d",
txn, key, str, iterStr, foundLock.Txn.Sequence)
}
return nil
}

Expand Down