roachtest: clean up artifacts zipping code#111151
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 26, 2023
Merged
roachtest: clean up artifacts zipping code#111151craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
RaduBerinde
requested review from
smg260 and
srosenberg
and removed request for
a team
Member
|
This change is |
This change rewrites the artifacts zipping code and adds a test. Instead of doing the walk twice (with the second one restricted to top-level entries), we first list and filter the directory entries. This will make it easy to reuse the code to first move go coverage artifacts to their own archive. Epic: none Release note: None
RaduBerinde
force-pushed
the
roachtest-zip-cleanup
branch
from
6a23bde to
e1f4781
Compare
srosenberg
approved these changes
Sep 26, 2023
Member
srosenberg
left a comment
srosenberg
left a comment
There was a problem hiding this comment.
Nice! Thanks for cleaning this up. This code wasn't touched in a while afaik; the most recent fix was to allow zip files in sub-directories [1], and the current implementation preserves that logic.
[1] #84085
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change rewrites the artifacts zipping code and adds a test.
Instead of doing the walk twice (with the second one restricted to top-level entries), we first list and filter the directory entries.
This will make it easy to reuse the code to first move go coverage artifacts to their own archive.
Epic: none
Release note: None