c-deps: support 16K pages for ARM64 #106929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
force-pushed
the
jemalloc-arm64-16kpage
branch
from
9efa275
to
27f8a10
Compare
rickystewart
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
This is fine but we need to re-build the pre-built c-deps. I'll wait until #106642 is merged to do that because we'll get conflicts otherwise. This can merge in the meantime (or you can wait until #106642 is merged, if you want to get everything in in one big commit).
Either way can you make sure to backport to 23.1?
|
Thanks @rickystewart! Yes, I plan to backport to 23.1. bors r+ |
We have had two reports of users not being able to run cockroach 23.1 on linux/arm64 with 16k pages (jemalloc does not support the page size). This change attempts to fix this by compiling jemalloc with 16K page support, only in the linux/arm64 configuration. Epic: None Informs: cockroachdb#106745 Release note: None
RaduBerinde
force-pushed
the
jemalloc-arm64-16kpage
branch
from
27f8a10
to
ac4e0b1
Compare
|
Canceled. |
RaduBerinde
force-pushed
the
jemalloc-arm64-16kpage
branch
from
ac4e0b1
to
5775115
Compare
|
bors r+ |
|
Build succeeded: |
|
blathers backport 23.1 |
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Jul 18, 2023
Epic: none Release note (build): On Linux/ARM64, use 16k page sizes in `jemalloc` Part of: cockroachdb#106745
craig bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
107128: c-deps: update archived c-deps to pick up #106929 r=rail,RaduBerinde a=rickystewart Epic: none Release note (build): On Linux/ARM64, use 16k page sizes in `jemalloc` Part of: #106745 107178: Revert "github-pull-request-make: temporary workaround" r=healthy-pod a=knz Epic: CRDB-18499 This reverts commit da33ea2. Not needed any more since is merged now. Co-authored-by: Ricky Stewart <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had two reports of users not being able to run cockroach 23.1 on linux/arm64 with 16k pages (jemalloc does not support the page size). This change attempts to fix this by compiling jemalloc with 16K page support, only in the linux/arm64 configuration.
Epic: None
Informs: #106745
Release note: None