roachtest: prevent shared mutable state across c2c roachtest runs #101220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, all `c2c/*` roachtests run with `--count` would provide incomprehensible results because multiple roachtest runs of the same test would override each other's state. Specifically, the latest call of `test_spec.Run()`, would override the `test.Test` harness, and `syncedCluster.Cluster` used by all other tests with the same registration. This patch fixes this problem by moving all fields in `replicationSpec` that are set during test execution (i.e. a `test_spec.Run` call), to a new `replicationDriver` struct. Now, `replicationSpec` gets defined during test registration and is shared across test runs, while `replicationDriver` gets set within a test run. Epic: None Release note: None
|
This change is |
msbutler
requested review from
srosenberg,
smg260 and
benbardin
and removed request for
a team
benbardin
approved these changes
Apr 11, 2023
|
TFTR! bors r=benbardin |
|
bors r=benbardin |
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Apr 14, 2023
101447: c2c: randomize node shutdown timing in roachtests r=stevendanna a=msbutler Previously, the c2c/nodeShutdown tests would only execute a shutdown after a high water mark was set and before a cutover timestamp was chosen. This patch randomizes the node shutdown to either occur during the initial scan, during this steady state phase, or during cutover. This patch also fixes an infra bug that caused /src shutdown tests to run on /dest and /coordinator tests to run on /worker introduced in #101220. Informs: #89487 Release note: none Co-authored-by: Michael Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all
c2c/*roachtests run with--countwould provide incomprehensible results because multiple roachtest runs of the same test would override each other's state. Specifically, the latest call oftest_spec.Run(), would override thetest.Testharness, andsyncedCluster.Clusterused by all other tests with the same registration.This patch fixes this problem by moving all fields in
replicationSpecthat are set during test execution (i.e. atest_spec.Runcall), to a newreplicationDriverstruct. Now,replicationSpecgets defined during test registration and is shared across test runs, whilereplicationDrivergets set within a test run.Epic: None
Release note: None