Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ui: add badges for filter elements #101138

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

maryliag
Copy link
Contributor

Backport 1/1 commits from #98988.

/cc @cockroachdb/release

Image on 22.2

Screenshot 2023-04-10 at 2 10 24 PM


Adds badges for each of the selected filters on SQL Activity and
Insights pages.

Part Of #98891

https://www.loom.com/share/e7417209fc704d71b2733f58609fb4de

Screenshot 2023-03-19 at 1 30 49 PM

Release note (ui change): Adds badges for each selected
filter on SQL Activity and Insights pages.


Release justification: small change, big impact feature

Adds badges for each of the selected filters on SQL Activity and
Insights pages.
Part Of cockroachdb#98891

Release note (ui change): Adds badges for each selected
filter on SQL Activity and Insights pages.
@maryliag maryliag requested a review from a team April 10, 2023 18:14
@blathers-crl
Copy link

blathers-crl bot commented Apr 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit b70c6c5 into cockroachdb:release-22.2 Apr 10, 2023
@maryliag maryliag deleted the backport22.2-98988 branch April 10, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants