Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: local lookupJoin node OOMs server easily #29389

Closed
jordanlewis opened this issue Aug 30, 2018 · 0 comments
Closed

sql: local lookupJoin node OOMs server easily #29389

jordanlewis opened this issue Aug 30, 2018 · 0 comments

Comments

@jordanlewis
Copy link
Member

Running TPCC stockLevel queries with local lookupJoin oom kills the server. It seems it is somehow creating an enormous ScanResponse, maybe a lack of batching?

Here's a heap profile.

localLookup.pprof.gz
@jordanlewis jordanlewis mentioned this issue Aug 30, 2018
Merged
craig bot pushed a commit that referenced this issue Aug 31, 2018
@jordanlewis
Merge #29397
9f1a5b5 
29397: sql: don't remove batch limit in local lookup join r=jordanlewis a=jordanlewis

Previously, the local lookup join node was created with an underlying
scan with an explicitly disabled batch limit. This is the wrong thing to
do, since that scan will be used as a full table scan - it needs a batch
limit to prevent OOM errors.

Closes #29389.

Release note: None

Co-authored-by: Jordan Lewis <[email protected]>
@craig craig bot closed this as completed in #29397 Aug 31, 2018
@jordanlewis jordanlewis mentioned this issue Aug 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordanlewis