Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui, server: remove login feature flag environment variable #26518

Closed
vilterp opened this issue Jun 7, 2018 · 1 comment
Closed

ui, server: remove login feature flag environment variable #26518

vilterp opened this issue Jun 7, 2018 · 1 comment
Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@vilterp
Copy link
Contributor

vilterp commented Jun 7, 2018

Currently login is enabled by starting a cluster in secure mode with the COCKROACH_EXPERIMENTAL_REQUIRE_WEB_LOGIN variable set to true. This was so that people could opt in to trying login. Once we're comfortable that login is good enough to be enabled for all secure clusters, we should remove the environment variable. Biggest blocker: #25526 (making an anonymous access mode so that people use the UI during and after a 2.0 => 2.1 upgrade without having to create users)

cc @piyush-singh (let's send out that anonymous access mode design doc), @couchand
@couchand couchand mentioned this issue Jun 7, 2018
Closed
@petermattis petermattis added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. labels Jul 21, 2018
@couchand couchand added A-webui-security and removed A-webui Triage label for DB Console (fka admin UI) issues. Add this if nothing else is clear. labels Aug 2, 2018
@couchand couchand mentioned this issue Aug 2, 2018
Closed
vilterp pushed a commit to vilterp/cockroach that referenced this issue Aug 7, 2018
@couchand
ui: require web login for secure clusters
58d9e63 
Closes: cockroachdb#6307
Closes: cockroachdb#18206
Closes: cockroachdb#26518
Release note (admin ui change): Login is now required for secure clusters.
Users log in with a regular database username, so that user must already have a
password set.  Insecure clusters do not require login, and have a visual
indicator showing that they are insecure.
vilterp pushed a commit to couchand/cockroach that referenced this issue Aug 9, 2018
@couchand
ui: require web login for secure clusters
d90517d 
Closes: cockroachdb#6307
Closes: cockroachdb#18206
Closes: cockroachdb#26518
Release note (admin ui change): Login is now required for secure clusters.
Users log in with a regular database username, so that user must already have a
password set.  Insecure clusters do not require login, and have a visual
indicator showing that they are insecure.
@vilterp
Copy link
Contributor Author

vilterp commented Oct 17, 2018

Gonna close this one since the COCKROACH_EXPERIMENTAL_REQUIRE_WEB_LOGIN env var is gone; replaced by the DISABLE_LOGIN variable. Removing that may be a good idea, but seems like its own discussion.

@vilterp vilterp closed this as completed Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-webui-security C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: require web login for secure clusters couchand/cockroach
3 participants
@vilterp @couchand @petermattis