Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: support and validate options in randomized testing #134119

Open
8 tasks
rharding6373 opened this issue Nov 1, 2024 · 1 comment
Open
8 tasks

cdc: support and validate options in randomized testing #134119

rharding6373 opened this issue Nov 1, 2024 · 1 comment
Assignees
@aerfrei
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@rharding6373
Copy link
Collaborator

rharding6373 commented Nov 1, 2024 •
edited by cockroach-jira-scripts
Loading

CDC should add support for and validate documented options in randomized testing. Options that make sense to test include:

  • diff
  • envelope
  • format
  • full_table_name
  • initial_scan
  • kafka_sink_config / pubsub_sink_config / webhook_sink_config (no extra validation required, since the randomized test is for correctness testing)
  • key_in_value
  • mvcc_timestamp

Jira issue: CRDB-43921
@rharding6373 rharding6373 added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Nov 1, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 1, 2024

cc @cockroachdb/cdc

@rharding6373 rharding6373 mentioned this issue Nov 11, 2024
Open
9 tasks
aerfrei added a commit to aerfrei/cockroach that referenced this issue Dec 23, 2024
@aerfrei
ccl/changeedccl: Add changefeed options into nemesis tests
08d12f6 
This work makes sure our nemesis tests for changefeeds randomize
over the options we use upon changefeed creation. This randomly adds
the key_in_value option (see below) and full_table_name option half
of the time and checks that the changefeed messages respect them in
the beforeAfter validator.

Note the following limitations: the full_table_name option, when on,
asserts that the topic in the output will be d.public.{table_name}
instead of checking for the actual name of the database/schema.

This change also does not add the key_in_value option when for the
webhook and cloudstorage sinks. Even before this change, since
key_in_value is on by default for those sinks, we remove the key
from the value in those testfeed messages for ease of testing.
Unfortunately, this makes these cases hard to test, so we leave them
out for now.

See also: cockroachdb#134119

Epic: CRDB-42866

Release note: None
@aerfrei aerfrei mentioned this issue Dec 23, 2024
Open
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 7, 2025
@aerfrei
ccl/changeedccl: Add changefeed options into nemesis tests
abdb56f 
This work makes sure our nemesis tests for changefeeds randomize
over the options we use upon changefeed creation. This randomly adds
the key_in_value option (see below) and full_table_name option half
of the time and checks that the changefeed messages respect them in
the beforeAfter validator.

Note the following limitations: the full_table_name option, when on,
asserts that the topic in the output will be d.public.{table_name}
instead of checking for the actual name of the database/schema.

This change also does not add the key_in_value option when for the
webhook and cloudstorage sinks. Even before this change, since
key_in_value is on by default for those sinks, we remove the key
from the value in those testfeed messages for ease of testing.
Unfortunately, this makes these cases hard to test, so we leave them
out for now.

See also: cockroachdb#134119

Epic: CRDB-42866

Release note: None
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 7, 2025
@aerfrei
ccl/changeedccl: add changefeed options into nemesis tests
3128c32 
This work makes sure our nemesis tests for changefeeds randomize
over the options we use upon changefeed creation. This randomly adds
the key_in_value option (see below) and full_table_name option half
of the time and checks that the changefeed messages respect them in
the beforeAfter validator.

Note the following limitations: the full_table_name option, when on,
asserts that the topic in the output will be d.public.{table_name}
instead of checking for the actual name of the database/schema.

This change also does not add the key_in_value option when for the
webhook and cloudstorage sinks. Even before this change, since
key_in_value is on by default for those sinks, we remove the key
from the value in those testfeed messages for ease of testing.
Unfortunately, this makes these cases hard to test, so we leave them
out for now.

See also: cockroachdb#134119

Epic: CRDB-42866

Release note: None
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 7, 2025
@aerfrei
ccl/changeedccl: add changefeed options into nemesis tests
c70abab 
This work makes sure our nemesis tests for changefeeds randomize
over the options we use upon changefeed creation. This randomly adds
the key_in_value option (see below) and full_table_name option half
of the time and checks that the changefeed messages respect them in
the beforeAfter validator.

Note the following limitations: the full_table_name option, when on,
asserts that the topic in the output will be d.public.{table_name}
instead of checking for the actual name of the database/schema.

This change also does not add the key_in_value option when for the
webhook and cloudstorage sinks. Even before this change, since
key_in_value is on by default for those sinks, we remove the key
from the value in those testfeed messages for ease of testing.
Unfortunately, this makes these cases hard to test, so we leave them
out for now.

See also: cockroachdb#134119

Epic: CRDB-42866

Release note: None
aerfrei added a commit to aerfrei/cockroach that referenced this issue Jan 9, 2025
@aerfrei
ccl/changeedccl: add changefeed options into nemesis tests
c9cafc0 
This work makes sure our nemesis tests for changefeeds randomize
over the options we use upon changefeed creation. This randomly adds
the key_in_value option (see below) and full_table_name option half
of the time and checks that the changefeed messages respect them in
the beforeAfter validator.

Note the following limitations: the full_table_name option, when on,
asserts that the topic in the output will be d.public.{table_name}
instead of checking for the actual name of the database/schema.

This change also does not add the key_in_value option when for the
webhook and cloudstorage sinks. Even before this change, since
key_in_value is on by default for those sinks, we remove the key
from the value in those testfeed messages for ease of testing.
Unfortunately, this makes these cases hard to test, so we leave them
out for now.

See also: cockroachdb#134119

Epic: CRDB-42866

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aerfrei aerfrei

Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rharding6373 @aerfrei