Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: port systemschema/validate-after-version-upgrade to new mixed-version framework #110535

Closed
srosenberg opened this issue Sep 13, 2023 · 1 comment · Fixed by #113643
Closed
Assignees
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@srosenberg
Copy link
Member

srosenberg commented Sep 13, 2023

See the parent issue #110528 for details. Also note, systemschema/validate-after-version-upgrade seems like a good candidate for the mixed-version logictest framework instead. It might also be a good opportunity to strengthen the assertions being verified by this test.

An example is here: #108802

Jira issue: CRDB-31485

@srosenberg srosenberg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Sep 13, 2023
@rafiss rafiss added the A-testing Testing tools and infrastructure label Sep 19, 2023
@blathers-crl
Copy link

blathers-crl bot commented Oct 1, 2023

Hi @lunevalex, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

craig bot pushed a commit that referenced this issue Nov 3, 2023
113643: roachtest: move validate-after-version-upgrade to new framework r=rafiss a=rafiss

The new framework provides a few more testing enhancements and is the only one that will be maintained.

fixes #110535
Release note: None

113676: roachtest: fix js install command (gpg) r=rafiss a=annrpom

We are seeing a `gpg: cannot open '/dev/tty': No such device or address` error from the new installation method we followed. Resolution seems to be nodejs/docker-node#922.

In case we are running into an issue with machines being reused, we
first check to see if we can install nodejs and npm before we add
a nodesource key and deb repository (to prevent gpg: dearmoring failed:
File exists) issues.

(Copied from a reply to the bug report in the issue linked above)
> For any script use you should anyway use --batch which disables the use
of the tty as a side-effect.

Fixes: #113673
Fixes: #113662
Fixes: #113659
Fixes: #113675
Fixes: #113677
Fixes: #113762

Release note: None

113698: metamorphic: add MVCC{CheckFor,}AcquireLock operations r=nvanbenschoten a=itsbilal

This change adds two new operations to the MVCC metamorphic testing package that were added in #110323. We check for determinism in the storage package by adding these operations to the metamorphic tests as well.

Fixes #109650.

Epic: none

Release note: None

Co-authored-by: Rafi Shamim <[email protected]>
Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in #113643 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants