Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apd: drop github.com/pkg/errors #124

Merged

Conversation

nvanbenschoten
Copy link
Member

Fixes #123.

Now that the stdlib's "errors" package supports wrapping, use it to eliminate a dependency on "github.com/pkg/errors".

Picks up the "lib/pq" test dependency. Bump go.mod to go 1.17 to allow users of the library to prune this dependency (https://go.dev/ref/mod#graph-pruning).

@mvdan do you mind giving this a look?

Pass `Decimal` by value to `DB.Exec`.

Also use new build tag directive format.
Fixes cockroachdb#123.

Now that the stdlib's "errors" package supports wrapping, use it to
eliminate a dependency on "github.com/pkg/errors".

Picks up the "lib/pq" test dependency. Bump `go.mod` to `go 1.17` to
allow users of the library to prune this dependency
(https://go.dev/ref/mod#graph-pruning).
@nvanbenschoten nvanbenschoten merged commit e2030eb into cockroachdb:master Sep 9, 2022
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/remErrors branch September 9, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please drop github.com/pkg/errors
2 participants