Don't free uninitialized local variables.

[mvollmer]

Jumping over the declaration of a local variable that has a destructor
doesn't work since the variable will be uninitialized when the
destructor runs.

[stefwalter]

This sorta thing is why I'm not a big fan of these automatic gcc destructors in C code.

[cgwalters]

I guess one just can't use it with C99 style declarations, but it's worked really well in my other codebases, and systemd uses it extensively.

I don't feel like C99 declarations are that big of a win anyways, I tend to just stick to C89.

[stefwalter]

Yeah, perhaps.

But it's such a shame that dtor stuff is negated by our out: style of function returns, and the fact that you have to carefully assign, initialize, track the values assigned to the dtor'd variables anyway. It doesn't really end up reducing the amount of code in so many of our use cases.

[mvollmer]

Of the three conflicting things (goto out, interleaved declarations, destructors), my least favourite is "goto out". If we manage to replace all of those with just "return", we should be good. This probably means we need to define destructors for more types than what libgsystem offers right now.