Skip to content

test: workaround an old (and very common) flake #19835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allisonkarlitskaya merged 1 commit into from
Jan 11, 2024
Merged

test: workaround an old (and very common) flake #19835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/verify/check-reauthorize
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ class TestReauthorize(testlib.MachineCase):
self.login_and_go("/playground/test")
b.click(".super-channel button")
b.wait_in_text(".super-channel span", 'result: ')
self.assertEqual(b.text(".super-channel span"), 'result: access-denied')

# TODO: this should only be 'access-denied'
legit_results = [f'result: {err}' for err in ('access-denied', 'authentication-failed', 'terminated')]
self.assertIn(b.text(".super-channel span"), legit_results)

b.logout()

# So first ask the user to retype their password
Expand Down