backport test fixes and bug fixes to RHEL 8 AppStream #12390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can run semaphore tests on this rhel-8-appstream branch.
Add a mechanism for skipping slow tests when requested by an environment variable (which we set, by default, when running tests under valgrind). Use this new API from the /ssh-bridge/echo-large test. For some reason, it's extremely slow under valgrind, particularly on i386 — slow enough that we're regularly hitting the alarm() timeout of 120 seconds on semaphore. Cherry-picked from master commit c7c3a6a.
Add some code to cockpit-bridge to detect if it's running under valgrind (ie: as part of 'make check-memory') and cause it to delay its exit by 5 seconds in that case. This helps avoid https://bugs.kde.org/show_bug.cgi?id=409367, which otherwise will cause the units test container to hang fairly regularly on Ubuntu 19.04. Cherry-picked from master commit 5716079.
git worktrees have a .git file instead of a directory. Relax the file type tests in our tools to get along with these. Cherry-picked from upstream commit ef49e35.
…e of the installation Only try to redefine the domain when the installation failed and the domain is appearing in the 'virsh list' command. In case the domain is not present, the user manually deleted the domain and in this case we should not undo the user's action. https://bugzilla.redhat.com/show_bug.cgi?id=1715399 Cherry-picked from master commit 9b3927
…active This commit calls the poolRefresh API everytime when fetching the list storage pools. This will trigger the refresh event to get emited, which will call the GET_STORAGE_POOL for each refreshed pool. Inactive pools don't have events, so call directly the GET_STORAGE_POOL method for those. This commit will allow the user to refresh pool data by reloading the browser page. https://bugzilla.redhat.com/show_bug.cgi?id=1680293 Cherry-picked from master commit 026dd4.
martinpitt
changed the title
Cherry-picked from master commit 2ad7ba6. Closes cockpit-project#12390
|
Backported fix for this crash as well. |
|
There's a timeout on check-realms on rhel-8-0-distropkg. But this PR doesn't touch pkg/realmd and doesn't aim at 8.0 (but 8.1), so I think it's good enough. |
|
Needs to rebase to master since #12367 changed tests names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.